Fix NoneType error in describe_images by filtering out None values in… #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, looks good to me, should be good to merge after you sign the CLA |
|
Check again, thanks |
|
Thank you! |
achantavy
approved these changes
Jun 17, 2024
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
lyft#1310) This merge request fixes an issue where the `describe_images` function in `cartography/intel/aws/ec2/images.py` encountered a NoneType error. The error occurred because None values were being included in the image_ids list, which is not allowed by the AWS SDK. In one particular account of several hundred tested, an image ID was returned that was None. I was able to verify that this allows all of my accounts to run ingestion successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes an issue where the
describe_imagesfunction incartography/intel/aws/ec2/images.pyencountered a NoneType error. The error occurred because None values were being included in the image_ids list, which is not allowed by the AWS SDK. In one particular account of several hundred tested, an image ID was returned that was None. I was able to verify that this allows all of my accounts to run ingestion successfully.