LoadBalancerV2 target groups: include port and protocol to EC2Instance #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achantavy
reviewed
Nov 29, 2023
| @@ -159,6 +159,7 @@ def load_load_balancer_v2_target_groups( | |||
| MERGE (elbv2)-[r:EXPOSE]->(instance) | |||
| ON CREATE SET r.firstseen = timestamp() | |||
| SET r.lastupdated = $update_tag | |||
| r.port = $PORT, r.protocol = $PROTOCOL | |||
There was a problem hiding this comment.
You missed a comma. Needs to be
SET r.lastupdated = $update_tag,
r.port = $PORT, r.protocol = $PROTOCOL
Also, is the ARN of the target group available? If so, maybe we should include the ARN of the target group as r.target_group_arn so that it's easily searchable.
There was a problem hiding this comment.
Oh also let's remember to update the schema doc
achantavy
requested changes
Dec 1, 2023
| ON CREATE SET r.firstseen = timestamp() | ||
| SET r.lastupdated = $update_tag | ||
| ON CREATE SET r.firstseen = timestamp(), | ||
| r.target_group_arn = $TARGET_GROUP_ARN |
There was a problem hiding this comment.
Is it possible for the target_group_arn to change? To be safe, let's move this to the SET clause.
achantavy
changed the title
achantavy
approved these changes
Dec 1, 2023
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
lyft#1278) AWS api exposes a port and protocol per TargetGroup (see https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_TargetGroup.html) Using those values to identify which EC2 instances are exposed by which protocols and ports based on LoadBalancer configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS api exposes a port and protocol per TargetGroup (see https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_TargetGroup.html)
Using those values to identify which EC2 instances are exposed by which protocols and ports based on LoadBalancer configuration.