Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GCP init only grabs first page of services if a lot of services are enabled #1273

Closed
neilroebert opened this issue Oct 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@neilroebert
Copy link
Contributor

Title: GCP init only grabs first page of services if a lot of services are enabled

Description:

The _services_enabled_on_project function only uses first page of services that are enabled on a project.

        res = req.execute()
        if 'services' in res:
            return {svc['config']['name'] for svc in res['services']}
        else:
            return set()

To Reproduce:

Enable a lot of services on GCP and run the ingestor

Logs:

Unfortunately not easy to explain in the logs.

Please complete the following information::

  • Cartography release version 0.86
@achantavy achantavy added the bug Something isn't working label Oct 30, 2023
chandanchowdhury pushed a commit to juju4/cartography that referenced this issue Jun 26, 2024
This fixes the issue mentioned in lyft#1273 

This adds the pagination to the service following how the rest of the
GCP intel modules do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants