Skip to content

Commit

Permalink
fix(ui): fix display banner when not explicit set position (argoproj#…
Browse files Browse the repository at this point in the history
…16741)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
  • Loading branch information
linghaoSu authored and lyda committed Mar 28, 2024
1 parent a0d3eec commit 1d7496d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ui/src/app/ui-banner/ui-banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export const Banner = (props: React.Props<any>) => {
chatUrl = 'invalid-url';
}
}
const shouldRenderTop = position === 'top' || position === 'both';
const shouldRenderTop = position === 'top' || position === 'both' || (!position && content);
const shouldRenderBottom = position === 'bottom' || position === 'both';
return (
<React.Fragment>
Expand Down

0 comments on commit 1d7496d

Please sign in to comment.