-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move recursive renderChildren call after appendChild #3
Conversation
✅ Deploy Preview for wesc-eleventy canceled.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for wesc-node canceled.
|
✅ Deploy Preview for wesc-remixrun canceled.
|
thank you! I will try to review this week |
Hello @luwes it was easier for me to copy your code and adapt it to our needs in our monorepo. Since we are developing our Web Components with Stencil.js and there are two changes (#4914 and #4916) in their code that we need, I created a minimal reproduction repository. My version of your code is here If you have any questions/ideas/feedback, let me know 🙂 . IMO you can close this PR and the other one if you don't need my changes. Thanks a lot for your work |
All good! I'm glad the project is useful to you. This PR LGTM! Will merge it in. |
Hi there @luwes, first of all very nice project it helped us a lot with SSR our web components within a Next.js app directory project. 🎉
What I encountered is if we have web components which use the
<slot>
-element within another web components<slot>
-element the reactrenderChildren
function gets somehow stucked in an infinite loop. I was able to fix it by moving the recursive call ofrenderChildren
after theappendChild
call.Since our code is on our customers private repository i can't provide you with some reproduction code.
Dummy codewise it looks something like this: