Add shadow for beam-runners-core-construction-java to direct runner #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatRfernand
approved these changes
Apr 5, 2018
lukecwik
reviewed
Apr 5, 2018
| @@ -44,6 +44,7 @@ dependencies { | |||
| compile project(path: ":beam-runners-core-java", configuration: "shadow") | |||
| compile project(path: ":beam-runners-local-java-core", configuration: "shadow") | |||
| shadow project(path: ":beam-sdks-java-core", configuration: "shadow") | |||
| shadow project(path: ":beam-runners-core-construction-java", configuration: "shadow") | |||
There was a problem hiding this comment.
This isn't the right fix, either the shadowJar configuration is wrong and we aren't doing the necessary relocation or we are publishing the unshaded artifact.
lukecwik
pushed a commit
that referenced
this pull request
Feb 26, 2020
merge after PR update 9/1/2020
lukecwik
pushed a commit
that referenced
this pull request
May 20, 2022
[WIP] Standard coders with their test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shadow for beam-runners-core-construction-java to direct runner
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.