Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arm platforms #368

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add support for arm platforms #368

merged 3 commits into from
Nov 10, 2023

Conversation

n-029894
Copy link
Contributor

@n-029894 n-029894 commented Nov 8, 2023

We are using jtl-reporter and planning on moving to arm-based nodes. Updating here so we don't have to build custom images.

@ludeknovy
Copy link
Owner

ludeknovy commented Nov 10, 2023 •
edited
Loading

Hi @n-029894 ! Thanks for your contribution.
More changes are required to make this really work, please see: https://github.com/ludeknovy/jtl-reporter-be/blob/master/.github/workflows/docker-push.yml

https://docs.docker.com/build/ci/github-actions/multi-platform/

Specifically, please, add the qemu and builx steps.
Update the docker/build-push-action to @5 as well.

@ludeknovy ludeknovy self-requested a review November 10, 2023 09:52
@n-029894
Copy link
Contributor Author

@ludeknovy Updated. Thanks for the feedback.

@ludeknovy ludeknovy merged commit 7b012a7 into ludeknovy:master Nov 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeknovy ludeknovy ludeknovy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-029894 @ludeknovy