Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45079: Execute only non-filtered notebooks when requesting explicit notebooks #363

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

fajpunk
Copy link
Member

@fajpunk fajpunk commented Jul 23, 2024

GitHub CI checks ask mobu to run an explicit list of notebooks. Some of these notebooks may be excluded once mobu picks up the job though.

This makes sure that these jobs runs the filtered notebooks in a single session.

Mobu could end up not actually running any notebooks, if all of the notebooks in the explicit list are excluded. In this case, mobu will conclude the check as a success. A future PR will make mobu conclude the check as neutral in this case.

@fajpunk fajpunk force-pushed the tickets/DM-45079/split-notebook-runner-options branch from 08fc1b3 to 8a97fb7 Compare July 23, 2024 20:10
@fajpunk fajpunk requested a review from rra July 23, 2024 20:11
@fajpunk fajpunk force-pushed the tickets/DM-45079/split-notebook-runner-options branch 2 times, most recently from 2c3dca8 to 792013f Compare July 23, 2024 20:19
Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me!

src/mobu/services/business/notebookrunner.py Outdated Show resolved Hide resolved
src/mobu/services/business/notebookrunner.py Show resolved Hide resolved
src/mobu/services/business/notebookrunner.py Show resolved Hide resolved
@fajpunk fajpunk force-pushed the tickets/DM-45079/split-notebook-runner-options branch from 792013f to c6a13a5 Compare July 23, 2024 21:12
@fajpunk fajpunk merged commit 9e45bc4 into main Jul 23, 2024
4 checks passed
@fajpunk fajpunk deleted the tickets/DM-45079/split-notebook-runner-options branch July 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants