DM-42182: Rename TAPQuerySetRunner, add new TAPQueryRunner #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than add a new layer of abstraction to allow two different configurations of TAPQueryRunner, abstract the common functionality of businesses that run TAP queries, rename the old TAPQueryRunner to TAPQuerySetRunner, and add a new TAPQueryRunner that takes a simple list of queries. This follows the existing pattern for keeping each business simple and supporting a variety of tests via separate business classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the previous
TAPQueryRunnerbusiness toTAPQuerySetRunnerand add a newTAPQueryRunnerbusiness that runs queries randomly chosen from a simple list.