DM-39552: Generate less data when summarizing flocks #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, to generate a flock summary, mobu first converted all information about the running monkeys to output data structures and then added up success and failure counts from those. Because of the huge amount of timing data that mobu gathers, this took long enough (and is not async, so it blocks everything else) that other in-progress calls timed out. It also meant that the summary end point appeared to hang. Avoid this by reading the success and failure counts directly from the running monkey business, avoiding the need to dump and thus convert their data. This is a temporary fix until the way that timing data is stored can be overhauled.
Requires one fix to avoid a new Ruff warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, to generate a flock summary, mobu first converted all information about the running monkeys to output data structures and then added up success and failure counts from those. Because of the huge amount of timing data that mobu gathers, this took long enough (and is not async, so it blocks everything else) that other in-progress calls timed out. It also meant that the summary end point appeared to hang.
Avoid this by reading the success and failure counts directly from the running monkey business, avoiding the need to dump and thus convert their data. This is a temporary fix until the way that timing data is stored can be overhauled.