DM-38425: Stream monkey logs instead of using FileResponse #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlette FileResponse no longer works to return monkey logs because it now commits to a Content-Length when starting to stream the file but doesn't stop sending data at that cutoff, so it sends more data than Content-Length since the log file is changing, and that in turn causes an HTTP protocol failure that prevents Chrome (at least) from successfully downloading the file. Instead, simulate that with StreamResponse while setting a Content-Disposition header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starlette FileResponse no longer works to return monkey logs because it now commits to a Content-Length when starting to stream the file but doesn't stop sending data at that cutoff, so it sends more data than Content-Length since the log file is changing, and that in turn causes an HTTP protocol failure that prevents Chrome (at least) from successfully downloading the file.
Instead, simulate that with StreamResponse while setting a Content-Disposition header.