DM-38339: Handle failures during TAPQueryRunner setup #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAPQueryRunner previously was creating a TAP client in __init__, which meant that failure to reach the TAP server caused the entire flock creation to fail. Move creation of the client to startup to correctly follow the Business API, and wrap it in a timer and better exception handling so that we get nice Slack reports. A business wasn't counting failures during startup as a failed execution, which meant that monkeys that kept failing during startup would show as 100% successful in the summary. Increment the failure count if startup raises an exception to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TAPQueryRunner previously was creating a TAP client in init, which meant that failure to reach the TAP server caused the entire flock creation to fail. Move creation of the client to startup to correctly follow the Business API, and wrap it in a timer and better exception handling so that we get nice Slack reports.
A business wasn't counting failures during startup as a failed execution, which meant that monkeys that kept failing during startup would show as 100% successful in the summary. Increment the failure count if startup raises an exception to avoid this.