DM-38339: Update mypy configuration and type annotations #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the current mypy configuration and fix various issues it uncovered. This unfortunately includes importing git module attributes from submodules since the way that GitPython dynamically creates its __all__ variable at the top level is incompatible with mypy.
Follow the PEP-585 recommendations to stop importing most types from the typing module. Start using Self types where appropriate. Stop using Optional in places where SQR-074 recommends | None instead, and use the | syntax instead of Union.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the current mypy configuration, and work around typing limitations in GitPython. Follow the PEP-585 recommendations for type imports, use lowercase types where possible, use the new union syntax where appropriate, and use Self where appropriate.