Fix some coding style issues in TAP code

Use snake_case instead of camelCase. Log whether the query was run
sync or async. Delete a disabled SQL query for DP0.2 data; we have
revision control, we don't need to rename files rather than
deleting them.

src/mobu/business/tapqueryrunner.py

@@ -115,11 +115,11 @@ def _generate_parameters(self) -> dict[str, int | float | str]:
             "username": self.user.username,
             "query_id": "mobu-" + shortuuid.uuid(),
         }
-        objectIds = self._params.get("objectIds")
-        if objectIds:
-            result["object"] = str(random.choice(objectIds))
+        object_ids = self._params.get("object_ids")
+        if object_ids:
+            result["object"] = str(random.choice(object_ids))
             result["objects"] = ", ".join(
-                str(o) for o in random.choices(objectIds, k=12)
+                str(o) for o in random.choices(object_ids, k=12)
             )
         return result
 
@@ -154,19 +154,17 @@ async def execute(self) -> None:
         self.logger.info(f"Query finished after {elapsed} seconds")
 
     async def run_async_query(self, query: str) -> None:
-        self.logger.info("Running: %s", query)
+        self.logger.info("Running (async): %s", query)
         job = self._client.submit_job(query)
-
         try:
             job.run()
-
-            while job.phase not in ["COMPLETED", "ERROR"]:
+            while job.phase not in ("COMPLETED", "ERROR"):
                 await asyncio.sleep(30)
         finally:
             job.delete()
 
     async def run_sync_query(self, query: str) -> None:
-        self.logger.info("Running: %s", query)
+        self.logger.info("Running (sync): %s", query)
         loop = asyncio.get_event_loop()
         await loop.run_in_executor(self._pool, self._client.search, query)
 

src/mobu/templates/tapqueryrunner/dp0.1/params.yaml

@@ -6,7 +6,7 @@ min_dec: -42.0
 max_dec: -30.0
 
 # 500 randomly selected objects across the entire spatial extent of DP0.1.
-objectIds:
+object_ids:
 - 15995858369670638
 - 15147293091046069
 - 15138492703093404

src/mobu/templates/tapqueryrunner/dp0.2-long-scans/params.yaml

@@ -7,7 +7,7 @@ max_dec: -28.0
 
 # Source list of 500 randomly selected objects across the entire spatial
 # extent of DP0.2.
-objectIds:
+object_ids:
 - 2093848371285467432
 - 1912481729260552963
 - 1821389389922580341

src/mobu/templates/tapqueryrunner/dp0.2-med-scans/params.yaml

@@ -7,7 +7,7 @@ max_dec: -28.0
 
 # Source list of 500 randomly selected objects across the entire spatial
 # extent of DP0.2.
-objectIds:
+object_ids:
 - 2093848371285467432
 - 1912481729260552963
 - 1821389389922580341

src/mobu/templates/tapqueryrunner/dp0.2/params.yaml

@@ -14,7 +14,7 @@ radius_near_range: 0.028
 
 # Source list of 500 randomly selected objects across the entire spatial
 # extent of DP0.2.
-objectIds:
+object_ids:
 - 2093848371285467432
 - 1912481729260552963
 - 1821389389922580341

tests/business/tapqueryrunner_test.py

@@ -155,7 +155,7 @@ async def test_alert(
 
 @pytest.mark.asyncio
 async def test_random_object() -> None:
-    for query_set in ["dp0.1", "dp0.2"]:
+    for query_set in ("dp0.1", "dp0.2"):
         params_path = (
             Path(mobu.__file__).parent
             / "templates"
@@ -164,12 +164,12 @@ async def test_random_object() -> None:
             / "params.yaml"
         )
         with params_path.open("r") as f:
-            objects = [str(o) for o in yaml.safe_load(f)["objectIds"]]
+            objects = [str(o) for o in yaml.safe_load(f)["object_ids"]]
 
-        logger = structlog.get_logger(__file__)
         user = AuthenticatedUser(
             username="user", scopes=["read:tap"], token="blah blah"
         )
+        logger = structlog.get_logger(__file__)
         with patch.object(pyvo.dal, "TAPService"):
             runner = TAPQueryRunner(
                 logger, BusinessConfig(tap_query_set=query_set), user