-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add endpoints for build agent information in local continuous integration
#7785
Development
: Add endpoints for build agent information in local continuous integration
#7785
Conversation
…ion-localci' into development/build-agent-information-localci
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. Work as expected. Code also LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demonstrated in testing session, works as expected. code also lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in a testing session, worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demonstrated in small testing session, works as expected 🚀
Checklist
General
Server
Motivation and Context
For admins, it might be interesting to get information on available build agents in local CI, e.g. number of build jobs currently running on an agent, build job capacity.
Description
This PR adds some REST endpoints to be later used for displaying build agent information on the client. Each hazelcast member adds itself to the list when the LocalCISharedBuildJobQueueService is initialized. The information is updated everytime a member processes a build job. When calling the endpoint, the list is updated to make sure that ex members who left the cluster will not be represented.
Steps for Testing
Prerequisites:
numberOfCurrentBuildJobs
should be 0 for all build agentsnumberOfCurrentBuildJobs
> 0Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests