[sram_ctrl,dv] Add readback_regwen test #24596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
force-pushed
the
sram_ctrl_regwen_dv
branch
from
89e66a1
to
efeba07
Compare
rswarbrick
reviewed
Sep 18, 2024
nasahlpa
force-pushed
the
sram_ctrl_regwen_dv
branch
2 times, most recently
from
b6c0326
to
c680d6e
Compare
nasahlpa
requested review from
hcallahan-lowrisc
and removed request for
a team
|
Thanks for your review, @rswarbrick. I've addressed your comments. |
rswarbrick
approved these changes
Sep 20, 2024
|
CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson (The change here is to add a description of a countermeasure, so there is no potential to break the design) |
|
CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson (No functional change, only adds a countermeasure description.) |
To close a coverage gap, this commit enhances the regwen_vseq to also cover the readback_regwen register. To reflect this change, the `sec_cm_readback_config_regwen` label is added. No functional RTL change. Now, EXPRESSION (readback_we & readback_regwen_qs) gets full cond. coverage. Closes lowRISC#24358. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
force-pushed
the
sram_ctrl_regwen_dv
branch
from
c680d6e
to
b2058de
Compare
|
CHANGE AUTHORIZED: hw/ip/sram_ctrl/data/sram_ctrl.hjson (No functional change, only adds a countermeasure description.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close a coverage gap, this commit enhances the regwen_vseq to also cover the readback_regwen register.
Closes #24358.