Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Cut down apt-requirements #24594

Closed
wants to merge 1 commit into from
Closed

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Sep 18, 2024

These system dependencies don't seem to be required any more.

I have a feeling many of these aren't required any more. Running through
CI to see what breaks.

Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
@jwnrt jwnrt marked this pull request as ready for review September 18, 2024 09:22
@jwnrt jwnrt requested a review from mundaym as a code owner September 18, 2024 09:22
@jwnrt jwnrt removed the request for review from mundaym September 18, 2024 09:23
@jwnrt jwnrt marked this pull request as draft September 18, 2024 09:35
@jwnrt jwnrt marked this pull request as ready for review September 18, 2024 11:34
@pamaury
Copy link
Contributor

pamaury commented Sep 18, 2024

I see that we have a cmake rule here.
I am not sure if this uses the system's cmake or not.

Our documentation recommends autoconf to build verilator here.

We also seem to depend on ninja in airgapped builds and in tool requirement checks and in some weird files.

I would first double-check if those files are outdated or not. If we remove the tools for apt, then we should update the doc/files.

@jwnrt
Copy link
Contributor Author

jwnrt commented Sep 18, 2024

Hmm, you're right. I was hoping CI would catch any problems but there are two reasons why it might not:

  • GitHub / Azure hosted runners come with some tools pre-installed (like cmake and autoconf)
  • Our self-hosted runners come with packages pre-installed in the container, but that container isn't updated automatically for this PR

@jwnrt
Copy link
Contributor Author

jwnrt commented Sep 18, 2024

I'm going to drop this, don't think it's worth the work.

@jwnrt jwnrt closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants