Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add quick_lint job to GitHub Actions CI workflow #24590

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Sep 17, 2024

In Azure, we use these quick lints as a filter before we run the rest of the pipeline. We need this job running in parallel in GitHub Actions to start porting things over.

  • I've dropped the "Determine build type" step as we don't need this right now and it's not a lint anyway.
  • I also dropped the "Confirm no .bazelrc-site" step since it's already in .gitignore and this check seems superfluous.
  • Otherwise, no changes.

This PR also ports the ci/install-dependencies.{sh,yml} files from Azure to GitHub (with some duplication). I'd still like to extract the Verilator and Verible versions to some external file. Same for the Python version ideally.

@jwnrt jwnrt marked this pull request as ready for review September 17, 2024 19:05
Copy link
Contributor

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks James

@jwnrt
Copy link
Contributor Author

jwnrt commented Sep 18, 2024

GitHub's cache action seems a little broken:

But I think I've gotten caching working with the following:

  • I've moved the EDA tool install location to /tmp/{verilator,verible} and it seems to be working.
  • I've changed the pip install step to be system-wide, not --user.
  • I've set -o Dir::Cache::archives=/tmp/apt-archives for apt and cached that directory.

@jwnrt jwnrt force-pushed the gha-quick-lint branch 7 times, most recently from b9d4a67 to 42f2f76 Compare September 18, 2024 10:24
@jwnrt jwnrt requested a review from pamaury September 18, 2024 10:32
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/actions/install-deps/action.yml Outdated Show resolved Hide resolved
.github/actions/install-deps/action.yml Outdated Show resolved Hide resolved
.github/actions/install-deps/action.yml Show resolved Hide resolved
.github/actions/install-deps/action.yml Outdated Show resolved Hide resolved
.github/actions/install-deps/action.yml Show resolved Hide resolved
.github/actions/install-deps/action.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jwnrt jwnrt force-pushed the gha-quick-lint branch 5 times, most recently from e14c7a7 to 5f3ecf6 Compare September 18, 2024 11:26
@jwnrt jwnrt requested a review from nbdd0121 September 18, 2024 11:26
@jwnrt jwnrt force-pushed the gha-quick-lint branch 6 times, most recently from 4e5bacb to ddccf36 Compare September 18, 2024 14:39
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
@jwnrt
Copy link
Contributor Author

jwnrt commented Sep 18, 2024

Changed setup-python to read the python version from pyproject.toml, but it chose to use 3.12. This is supposedly supported by our pyproject.toml but doesn't work yet.

Getting OpenTitan working on 3.12 looks like a non-trivial amount of work, so deferring for another PR.

@jwnrt jwnrt merged commit 731bcc3 into lowRISC:master Sep 18, 2024
33 of 38 checks passed
@jwnrt jwnrt deleted the gha-quick-lint branch September 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants