[silicon_creator,hmac] ensure process cmd is only invoked once
#24030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
requested review from
moidx,
gdessouky,
jadephilipoom and
vogelpi
This updates the HMAC silicon_creator driver to separate out the `hmac_sha256_process()` call from the `hmac_sha256_final...()` calls to avoid sending multiple process commands to the hardware, and thus triggering an SVA in sim (see lowRISC#23954). While the consensus in lowRISC#24022 was that the hardware can handle multiple `process` commands, this path is less tested. Hence, we make this update to minimize risk in the ROM code that drives the HMAC SHA2 engine. This updates the ROM, and fixes lowRISC#23954. A new rom release candidate will tagged after this merges. Signed-off-by: Tim Trippel <ttrippel@google.com>
timothytrippel
force-pushed
the
fix-hmac-double-process
branch
from
04e03e7
to
09de390
Compare
moidx
approved these changes
Jul 16, 2024
|
CHANGE AUTHORIZED: sw/device/silicon_creator/rom/e2e/release/rom_e2e_self_hash_test.c |
vogelpi
approved these changes
Jul 16, 2024
|
CHANGE AUTHORIZED: sw/device/silicon_creator/rom/e2e/release/rom_e2e_self_hash_test.c |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the HMAC silicon_creator driver to separate out the
hmac_sha256_process()call from thehmac_sha256_final...()calls to avoid sending multiple process commands to the hardware, and thus triggering an SVA in sim (see #23954). While the consensus in #24022 was that the hardware can handle multipleprocesscommands, this path is less tested. Hence, we make this update to minimize risk in the ROM code that drives the HMAC SHA2 engine.This updates the ROM, and fixes #23954. A new rom release candidate will tagged after this merges.