[hw/pulp_riscv_dbg] Fix reset value of tap_state_q
#24018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes upstream issue pulp-platform/riscv-dbg#165 by applying upstream PR pulp-platform/riscv-dbg#169. The change gets applied in a patch to avoid re-vendoring, which would be inconvenient at the current time. This also reverts commit bd76d92 "[jtag,dv] Allow the jtag monitor to "reset" to a different TAP state" and commit 3b41400 "[rv_dm,dv] Teach environment about TAP's reset FSM state", which together replicated this problem in our DV code. Signed-off-by: Andreas Kurth <adk@lowrisc.org>
vogelpi
approved these changes
Jul 15, 2024
|
CHANGE AUTHORIZED: hw/vendor/pulp_riscv_dbg/src/dmi_jtag_tap.sv |
|
CHANGE AUTHORIZED: hw/vendor/pulp_riscv_dbg/src/dmi_jtag_tap.sv |
|
I just ran a full block-level regression, and results seem comparable to current nightlies:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes upstream issue pulp-platform/riscv-dbg#165 by applying upstream PR pulp-platform/riscv-dbg#169. The change gets applied in a patch to avoid re-vendoring, which would be inconvenient at the current time.
This also reverts commit bd76d92 "[jtag,dv] Allow the jtag monitor to "reset" to a different TAP state" and commit 3b41400 "[rv_dm,dv] Teach environment about TAP's reset FSM state", which together replicated this problem in our DV code.
This fixes #24019.