-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO] prim_count.sv CDC #24119
Labels
ECO_C
A potential candidate for an ECO
Milestone
Comments
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this issue
Jul 25, 2024
The escalation output request signal the prim_esc_receiver is a combinatorial signal. Before feeding this into a synchronizer primitive, it must be flopped once more in the source clock domain. Otherwise, this can lead to CDC issues. This resolves lowRISC#24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this issue
Jul 25, 2024
This is related to lowRISC#24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this issue
Jul 25, 2024
This is related to lowRISC#24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
added a commit
to vogelpi/opentitan
that referenced
this issue
Jul 25, 2024
This is related to lowRISC#24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Update: it has been decided to take a more holistic approach and fix all prim_count instances + the prim_esc_receiver instances: |
vogelpi
added a commit
that referenced
this issue
Jul 25, 2024
This is related to #24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi
added a commit
that referenced
this issue
Jul 25, 2024
This is related to #24119. Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Reported by: @meisnere
sw_alert_handler_ping_ok
test fails post synthesis.The root cause seems to point to glitches on
err_o
. This is a CDC error as it takes time for the sum to converge here:opentitan/hw/ip/prim/rtl/prim_count.sv
Lines 140 to 143 in e439226
CC @andreaskurth @vogelpi
The text was updated successfully, but these errors were encountered: