Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better description for shrink database button #4814

Merged

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

As discussed in #2470 (comment)

Previous description suggested that you need to recreate your database from scratch.
This PR is a rebase of PR #4508

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

image

@CommanderStorm CommanderStorm added house keeping pr:needs other pr merged pending other PR to be merged first labels Jun 3, 2024
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Jun 3, 2024
@CommanderStorm CommanderStorm merged commit e40ce59 into master Oct 4, 2024
17 checks passed
@CommanderStorm CommanderStorm deleted the better-description-for-shrink-database-button branch October 4, 2024 01:10
CommanderStorm added a commit that referenced this pull request Oct 4, 2024
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@Saibamen
Copy link
Contributor

Saibamen commented Oct 5, 2024

@CommanderStorm @louislam: Why this wasn't merged into 1.23.X branch and not goes into 1.23.14 release?

@CommanderStorm
Copy link
Collaborator Author

I moved this into v2.0 as changing the translations is something which weblate is a bit.. not robust with.

While translating with multiple branches might work, I'd rather not try weblate.
Merging conflicts is pretty painfull and not somethign that I can deal with. Only @louislam can fix these issues and I'd rather not waste his time with this.

Case in point, I broke weblate accidentally via this PR and how I handled merging 👀: #5072 (comment)

@Saibamen
Copy link
Contributor

Saibamen commented Oct 6, 2024

Maybe because we have really old Weblate?
Our version is 4.16.4, but latest version is 5.7.2 https://github.com/WeblateOrg/weblate/releases
FYI @louislam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping pr:needs other pr merged pending other PR to be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants