Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dft mc #249

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Dft mc #249

wants to merge 6 commits into from

Conversation

james-priestley
Copy link
Contributor

Convert displacements to integers when using the correct method of MotionEstimationStrategy, which resolves errors encountered when using DiscreteFourier2D (which produces float displacements even when upsample is 1).

Also fixed an error in DiscreteFourier2D encountered with multiplane data, due to the displacement array being re-preallocated with zeros within the plane for loop.

james-priestley and others added 5 commits August 28, 2018 21:33
…eFourier2D motion estimation strategy. Displacements are returned as floats, which subsequently throws an error during slicing for estimating pixel observations
…rwrite displacements with zero shifts except the last plane processed
Changed handling of multichannel data from an error to a warning, so the script behavior matches what's described in the warning message (uses channel 0). In particular, this fixes an incompatibility with ResonantCorrection, which adds an extra channel to the sequences.
@jzaremba jzaremba self-requested a review August 29, 2018 14:45
Copy link
Member

@jzaremba jzaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@james-priestley
Copy link
Contributor Author

Added another bit to get whole-frame displacements to play nicely with ResonantCorrection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants