Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(1.8.0): auto-salvage support for v2 volumes #994

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8430

What this PR does / why we need it:

Add important notes about auto-salvage support for v2 volumes.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn#9486

@c3y1huang c3y1huang self-assigned this Sep 24, 2024
longhorn/longhorn-8430

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 104868c
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66f219097d17f70008b2ff03
😎 Deploy Preview https://deploy-preview-994--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo.

@@ -230,6 +231,8 @@ Before Longhorn v1.7.0, Longhorn block-type disks only supported the SPDK AIO bd

Filesystem trim is supported since Longhorn v1.7.0. If a disk is managed by the SPDK AIO bdev driver, the Trim (UNMAP) operation is not recommended in a production environment (ref). It is recommended to manage a block-type disk with an NVMe bdev driver.

Staring with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Staring with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation.
Starting with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants