You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only delete backups' resources (BackupVolume, BackupBackingImage, SystemBackup, and Backup) when synchronization.
Add the label DeleteCustomResourceOnly, and delete remote backup data when deleting the corresponding backup resource in the cluster and the label does not exist.
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a validation/mutation webhook?
If the owner of a Backup/BackupVolume contains LabelLonghornDeleteResourceOnly, the webhook should add this label for the Backup/BackupVolume as well.
Do we need to add a validation/mutation webhook?
If the owner of a Backup/BackupVolume contains LabelLonghornDeleteResourceOnly, the webhook should add this label for the Backup/BackupVolume as well
Modified the BackupVolume mutation to check if the backup volume contains the label delete-custom-resource-only and add the label to backups of the backup volume.
Only delete backups' resources (BackupVolume, BackupBackingImage,
SystemBackup, and Backup) when synchronization.
Add the label `DeleteCustomResourceOnly`, and delete remote backup
data when deleting the corresponding backup resource in the cluster
and the label does not exist.
ref: longhorn/longhorn 9530
Signed-off-by: James Lu <james.lu@suse.com>
I just checked with the image jamesluhz/lh-manager:v1008issue9530webber01 provided by @mantissahz, the backup data will not be deleted on the remote target, but the backups will not be recovered until the next backupstore poll interval. From my code reading, it seems to be expected by design?
the backup data will not be deleted on the remote target, but the backups will not be recovered until the next backupstore poll interval. From my code reading, it seems to be expected by design?
@WebberHuang1118,
Yes, it is expected because we do not know whether the deleting with an empty response from backupstore is correct or not. We only can get the backup information back when there is correct backup information from the backupstore at synchronization (for every polling interval).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mantissahz
requested review from
ChanYiLin,
derekbit,
WebberHuang1118,
c3y1huang,
shuo-wu and
a team
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#9530
What this PR does / why we need it:
Only delete backups' resources (BackupVolume, BackupBackingImage, SystemBackup, and Backup) when synchronization.
Add the label
DeleteCustomResourceOnly, and delete remote backup data when deleting the corresponding backup resource in the cluster and the label does not exist.Special notes for your reviewer:
Additional documentation or context