Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use max[Width|Height] when fitImagesInViewport is false #660

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

k-iwanishi
Copy link
Contributor

@k-iwanishi k-iwanishi commented May 24, 2019

Pull Requests are welcome. But v2 of Lightbox is in Maintenance Mode.
No new features are planned. See the Roadmap.

PRs submitted will still be reviewed and kept open for others to utilize.

Hi, I like lightbox.

When fitImagesInViewport option is false, maxWidth and maxHeight is ignore.
But I want to use the following option for large and long image(e.g.: 1920x4320).

lightbox.option({
  'fitImagesInViewport': false,
  'maxWidth': 800
})

This PR modify to use maxWidth and maxHeight when fitImagesInViewport is false.

@lokesh
Copy link
Owner

lokesh commented Jul 14, 2019

@k-iwanishi thanks for catching this bug and making the PR. 🙏

I'm going to merge and do a patch release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants