Auth token in session storage instead of local storage #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sperry94
changed the title
sperry94
added a commit
that referenced
this pull request
Jan 30, 2020
* updating nm-web-shared dev package * updating shared pkg dev version * updating shared web pkg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the user auth token in session storage instead of local storage. That will cause users' authentications to clear when they close their browser.
This will eliminate a use-case in defect (Rally Ticket), where the user closes their browser, losing their kibana authentication but keeping their admin authentication.
NOTE: Be sure to upgrade BOTH nm-web-app and kibana when testing this PR, otherwise you will get ping-ponging between the UI pages.
NOTE: This PR should not be merged until this PR is merged.
nm-web-shared PR
nm-web-app PR