DA: Replication behavior membership test #805
Merged
+244
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
approved these changes
Oct 3, 2024
|
|
||
| while !completed { | ||
| completed = true; | ||
| for i in &pending_behaviours.clone() { |
There was a problem hiding this comment.
Debugging artifacts, removed.
bacv
force-pushed
the
da-replication-behaviour-tests
branch
from
b6cac5a
to
117fa04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR implement?
This PR tests functionality implemented in #680 and subsequent code changes, which should follow replication spec
Closes #773
2. Does the code have enough context to be clearly understood?
Comments are added to the
test_replication_behaviour()to explain what is expected.3. Who are the specification authors and who is accountable for this PR?
@bacv @danielSanchezQ
4. Is the specification accurate and complete?
Yes
5. Does the implementation introduce changes in the specification?
Tests were successful, no changes are required to the specification
Checklist