[WIP] Surreal backend #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
reviewed
Nov 21, 2022
| } | ||
|
|
||
| async fn store(&mut self, key: Bytes, value: Bytes) -> Result<(), Self::Error> { | ||
| let mut tx = self.surreal.transaction(true, false).await?; |
There was a problem hiding this comment.
(unrelated) that's not a very intuitive API
There was a problem hiding this comment.
YEah, too flaggy...not rusty
| } | ||
|
|
||
| async fn load(&mut self, key: &[u8]) -> Result<Option<Bytes>, Self::Error> { | ||
| let mut tx = self.surreal.transaction(true, false).await?; |
There was a problem hiding this comment.
Good catch!
zeegomo
approved these changes
Nov 21, 2022
|
I'm stalling this for the moment, as it is incompatible in windows. Waku uses mingw-gcc target only while |
danielSanchezQ
force-pushed
the
surreal-backend
branch
from
6ad3e72
to
13eaaeb
Compare
|
I'm closing this. Not really needed, and the bothersome it brings to the build system is not worth the price (at least for the time being). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SurrealDB as storage backend.