Implemented get_blob on sampling rocksdb adapter #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacv
approved these changes
Sep 6, 2024
Comment on lines
68
to
77
| let blob_bytes = load_blob( | ||
| self.settings.blob_storage_directory.clone(), | ||
| blob_id.as_ref(), | ||
| &column_idx.to_be_bytes(), | ||
| ) | ||
| .await | ||
| .unwrap(); | ||
| Ok(S::deserialize(blob_bytes) | ||
| .map(|blob| Some(blob)) | ||
| .unwrap_or_default()) |
There was a problem hiding this comment.
Just a suggestion for grouping deserialization with the loading. The load_blob().unwrap() can be changed to ?.
Suggested change
| let blob_bytes = load_blob( | |
| self.settings.blob_storage_directory.clone(), | |
| blob_id.as_ref(), | |
| &column_idx.to_be_bytes(), | |
| ) | |
| .await | |
| .unwrap(); | |
| Ok(S::deserialize(blob_bytes) | |
| .map(|blob| Some(blob)) | |
| .unwrap_or_default()) | |
| let blob = S::deserialize( | |
| load_blob( | |
| self.settings.blob_storage_directory.clone(), | |
| blob_id.as_ref(), | |
| &column_idx.to_be_bytes(), | |
| ) | |
| .await?, | |
| ) | |
| .map(|b| Some(b)) | |
| .unwrap_or_default(); | |
| Ok(blob) |
There was a problem hiding this comment.
Actually your variant is better, only lets change the unwrap and it's good to go!
holisticode
requested review from
bacv and
danielSanchezQ
and removed request for
danielSanchezQ
bacv
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a get_blob implementation on the rocksdb Adapter for the sampling service.