Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA: Verifier and Indexer in Node #713

Merged
merged 2 commits into from
Aug 30, 2024
Merged

DA: Verifier and Indexer in Node #713

merged 2 commits into from
Aug 30, 2024

Conversation

bacv
Copy link
Member

@bacv bacv commented Aug 30, 2024

Verifier and Indexer services were created and tested in a simplified node, this PR integrates them into the Nomos Node.

@bacv bacv self-assigned this Aug 30, 2024
Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Except for the verification with public keys which I think should be removed from the verifier is ok. It can be done in a different pr though.

Comment on lines +35 to +49
let secret_key =
SecretKey::from_bytes(&bytes).expect("Secret key should be reconstructed from bytes");

let nodes_public_keys = settings
.nodes_public_keys
.iter()
.map(|pk_hex| {
let pk_bytes =
hex::decode(pk_hex).expect("Public key string should decode to bytes");
PublicKey::from_bytes(&pk_bytes)
.expect("Public key should be reconstructed from bytes")
})
.collect::<Vec<PublicKey>>();

let verifier = NomosKzgrsVerifier::new(secret_key, &nodes_public_keys);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed anymore. But i have to check on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that sk is not used anymore, but the index is still required. Lets do it in a separate PR.

@bacv bacv merged commit 7dc2111 into master Aug 30, 2024
11 checks passed
@bacv bacv deleted the da-verifier-indexer-node branch August 30, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants