Add option to provide custom writer to the logger backend #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,6 +158,7 @@ impl ServiceCore for Logger { | |||
| } | |||
| LoggerBackend::Stdout => tracing_appender::non_blocking(std::io::stdout()), | |||
| LoggerBackend::Stderr => tracing_appender::non_blocking(std::io::stderr()), | |||
| LoggerBackend::Writer(writer) => tracing_appender::non_blocking(writer), | |||
There was a problem hiding this comment.
Could you elaborate on the use case of this writer? For example, sending logs via network to fluentd?
There was a problem hiding this comment.
Main reason was because I wanted to collect logs in the chat app but at the same time control how those are printed to stdout.
I think it could also be useful in tests where instead of dumping logs into a file and then reading you could directly read them on the fly.
This is general enough that it can be used in multiple ways I think
There was a problem hiding this comment.
I get it. Thank you for your comment!
bacv
approved these changes
Nov 7, 2023
danielSanchezQ
approved these changes
Nov 7, 2023
al8n
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Add option to provide custom writer to the logger backend * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be helpful in tests or other cases where you want to collect and process logs produced by another application in real time