-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deployment): ingest version checking #2859
Conversation
Looks great! I see how this catches the case where we want to update the deployment before the config changes have rolled out. |
So two things: (A) this would work - what the reloader basically does is to trigger a new pod to be created - so the initContainers would run again |
ah awesome! Didn't think that reloader caused initContainers to run again but you are correct! |
We encountered an issue during a rollout in which the config map was changed and triggered a reload of the pod [edit: actually we didn't have the reloader - so I'm not sure if that is it] before the pod itself was upgraded to the next version, causing double version bumps in staging. This avoids that by making the config map contain the loculus version that it targets and making an initContainer in the deployment that checks that this matches that expected by the deployment.
https://ingest-version-checking.loculus.org/