feat(website): Only count latest versions for stats on main page #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
added
the
format_me
theosanderson
changed the title
|
Nevermind, I missed that getRecent only counts version 1s anyways |
chaoran-chen
approved these changes
Sep 17, 2024
|
I tested that this is working and I now believe there are (almost) no edge cases 🥳 |
| @@ -49,7 +50,8 @@ const getTotalAndLastUpdatedAt = async ( | |||
| const client = LapisClient.createForOrganism(organism); | |||
| return ( | |||
| await client.call('aggregated', { | |||
| version: 1, | |||
| [VERSION_STATUS_FIELD]: siloVersionStatuses.latestVersion, | |||
There was a problem hiding this comment.
Maybe we should rename the function to getTotalUnrevokedAndLastUpdatedAt
There was a problem hiding this comment.
Personally I think this is ok as is (but I can live with the other option too)
| @@ -67,12 +69,22 @@ const getTotalAndLastUpdatedAt = async ( | |||
| const getRecent = async (organism: string, numberDaysAgo: number): Promise<number> => { | |||
| const recentTimestamp = Math.floor(Date.now() / 1000 - numberDaysAgo * 24 * 60 * 60); | |||
| const client = LapisClient.createForOrganism(organism); | |||
| return ( | |||
| const recentTotal = ( | |||
There was a problem hiding this comment.
recentTotalIncludingRevoked
corneliusroemer
added a commit
that referenced
this pull request
Sep 17, 2024
Also some slight tweaks to function names in organism statistics, follow up to #2814
corneliusroemer
added a commit
that referenced
this pull request
Sep 17, 2024
* refactor(website): rename `siloVersionStatus` to `versionStatus` Also some slight tweaks to function names in organism statistics, follow up to #2814 Coauthered by Theo
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://only-count-latest-version.loculus.org/