-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test database persistency on argocd #2807
base: main
Are you sure you want to change the base?
Conversation
@@ -39,5 +39,5 @@ spec: | |||
- name: POSTGRES_HOST_AUTH_METHOD | |||
value: "trust" | |||
- name: LOCULUS_VERSION | |||
value: {{ $dockerTag }} | |||
value: "commit-e3f268f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For info - this isn't consumed at all by Postgres so it could also just be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It is used specifically to cause the db to be recreated because that is useful in some scenarios)
ad0aa82
to
719ae2f
Compare
89ba64b
to
20a9eaf
Compare
Looks like the culprit is this error in SILO preprocessing:
|
This makes sense - |
I think it makes total sense now that we see this behavior. We could either alter get-released-data to do this check (doesn't really make sense) or as already suggested just increase the version of the preprocessing pipeline causing all samples to have the new fields. Also we allow the json to not include all metadata fields and just assume they are null if not given |
80283b3
to
28bbb62
Compare
resolves #
preview URL:
Summary
Launch database then try adding more metadata fields to this persistent database, currently running here: https://test-presistent.loculus.org/.
Then:
Hmmm... the page is behaving ok but I see some LAPIS issues when I look at argo (SILO pods are degraded):
maybe this is just due to LAPIS being restarted? Hmm... search and download is working... interesting so LAPIS for cchf seems to have restarted logs look fine and downloads now include the new metadata fields, however for west nile and ebola where the SILO pods are degraded downloads do not include the new fields
Ok I tried to force the SILO pods to restart by deleting the old ones but they stay in this state.
So it would seem that until new sequences are uploaded which include all metadata fields the new SILO pods cannot start...
Screenshot
PR Checklist