Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming file is not enough to change the docker image cache hash in our CI #2838

Open
corneliusroemer opened this issue Sep 18, 2024 · 1 comment · Fixed by #2839
Open

Renaming file is not enough to change the docker image cache hash in our CI #2838

corneliusroemer opened this issue Sep 18, 2024 · 1 comment · Fixed by #2839
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@corneliusroemer
Copy link
Contributor

@anna-parker hit an interesting bug in our docker image hash cache strategy.

She changed a file name only, and to our current hashing strategy file names do not seem to matter.

This is a bug - I should fix it, for now workaround is to make a trivial change in a readme for example.
@corneliusroemer corneliusroemer added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Sep 18, 2024
corneliusroemer added a commit that referenced this issue Sep 18, 2024
@corneliusroemer
fix: make filename changes change file hash
cb5fbcb 
partially resolves #2838
@corneliusroemer corneliusroemer mentioned this issue Sep 18, 2024
Merged
corneliusroemer added a commit that referenced this issue Sep 18, 2024
@corneliusroemer
fix: make filename changes change file hash
db45744 
partially resolves #2838
@corneliusroemer
Copy link
Contributor Author

We need to mirror the change to the other workflows as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): make filename changes change file hash in docker cache loculus-project/loculus
1 participant
@corneliusroemer