feat: better calcs for whether we can survive shoot ghost #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1009,3 +1009,51 @@ boolean wantToForceDrop(monster enemy) | |||
| return forceDrop; | |||
| } | |||
|
|
|||
| boolean canSurviveShootGhost(monster enemy, int shots) { | |||
There was a problem hiding this comment.
This is nice but shouldn't expected_damage(monster) return this information rather than requiring scripts to hardcode all this individually?
There was a problem hiding this comment.
I don't think so.
expected_damage(monster) says "if the monster attacks us normally, what damage do we expect to take?". The round we use Shoot Ghost, and all subsequent rounds, the ghost does more damage. But we don't know, from an expected_damage call, whether the user intends to use Shoot Ghost or not. Also, Mafia doesn't store the skills used in a particular combat, so it doesn't know whether the user has used Shoot Ghost or not.
Malibu-Stacey
force-pushed
the
better-shoot-ghost
branch
from
43a04ae
to
1dd0346
Compare
Malibu-Stacey
approved these changes
Sep 20, 2024
Malibu-Stacey
force-pushed
the
better-shoot-ghost
branch
from
1dd0346
to
c9f8ee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protonic ghosts do damage based on max HP. If we are an muscle class with high max HP and low elemental resistance, the previous calculation lead to unexpected death.
How Has This Been Tested?
Ran with it, successfully skipped and killed ghosts as expected.
Might be a bit cautious but I think it's better than dying.
Checklist: