Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve Parameter subclass when copying Parameters #964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions lmfit/parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,7 @@ def __deepcopy__(self, memo):
parameter_list = []
for key, par in self.items():
if isinstance(par, Parameter):
param = Parameter(name=par.name,
value=par.value,
min=par.min,
max=par.max)
param.vary = par.vary
param.brute_step = par.brute_step
param.stderr = par.stderr
param.correl = deepcopy(par.correl)
param.init_value = par.init_value
param.expr = par.expr
param.user_data = deepcopy(par.user_data)
param = deepcopy(par)
parameter_list.append(param)

_pars.add_many(*parameter_list)
Expand Down Expand Up @@ -990,6 +980,20 @@ def expr(self, val):
"""
self.__set_expression(val)

def __deepcopy__(self, memo):
param = type(self)(name=self.name,
value=self.value,
min=self.min,
max=self.max)
param.vary = self.vary
param.brute_step = self.brute_step
param.stderr = self.stderr
param.correl = deepcopy(self.correl)
param.init_value = self.init_value
param.expr = self.expr
param.user_data = deepcopy(self.user_data)
return param

def __set_expression(self, val):
if val == '':
val = None
Expand Down
11 changes: 11 additions & 0 deletions tests/test_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,17 @@ def test_parameters_deepcopy(parameters):
deepcopy_pars._asteval.symtable[unique_symbol])


def test_parameter_deepcopy_subclass():
"""Test that a subclass of parameter is preserved when performing a deepcopy"""
class ParameterSubclass(lmfit.Parameter):
pass

parameters = lmfit.Parameters()
parameters.add(ParameterSubclass('name'))
parameterscopy = deepcopy(parameters)
assert isinstance(parameterscopy['name'], ParameterSubclass)


def test_parameters_deepcopy_subclass():
"""Test that a subclass of parameters is preserved when performing a deepcopy"""
class ParametersSubclass(lmfit.Parameters):
Expand Down
Loading