-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[llvm-reduce] extractGVsFromModule(): don't crash when deleting instr…
… twice As it can be seen in newly-added (previously-crashing) test-case, there can be a situation where multiple GV's are used in instr, and we would schedule the same instruction to be deleted several times, crashing when trying to delete it the second time. We could either store WeakVH (done here), or use something set-like. I think using WeakVH is prevalent in these cases elsewhere.
- Loading branch information
Showing
3 changed files
with
43 additions
and
3 deletions.
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
llvm/test/Reduce/Inputs/remove-multiple-use-of-global-vars-in-same-instruction.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import sys | ||
|
||
FunctionCallPresent = False | ||
|
||
input = open(sys.argv[1], "r") | ||
for line in input: | ||
if "call void @use" in line: | ||
FunctionCallPresent = True | ||
|
||
if FunctionCallPresent: | ||
sys.exit(0) # Interesting! | ||
|
||
sys.exit(1) |
24 changes: 24 additions & 0 deletions
24
llvm/test/Reduce/remove-multiple-use-of-global-vars-in-same-instruction.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
; Test that llvm-reduce can remove uninteresting function arguments from function definitions as well as their calls. | ||
; | ||
; RUN: rm -rf %t | ||
; RUN: llvm-reduce --test %python --test-arg %p/Inputs/remove-multiple-use-of-global-vars-in-same-instruction.py %s -o %t | ||
; RUN: cat %t | FileCheck -implicit-check-not=uninteresting %s | ||
|
||
; CHECK: @uninteresting1 = global | ||
; CHECK: @uninteresting2 = global | ||
; CHECK: @uninteresting3 = global | ||
@uninteresting1 = global i32 0, align 4 | ||
@uninteresting2 = global i32 0, align 4 | ||
@uninteresting3 = global i32 0, align 4 | ||
|
||
declare void @use(i32*, i32*, i32*) | ||
|
||
; CHECK-LABEL: @interesting() | ||
define void @interesting() { | ||
entry: | ||
; CHECK: call void @use(i32* @uninteresting1, i32* @uninteresting2, i32* @uninteresting3) | ||
call void @use(i32* @uninteresting1, i32* @uninteresting2, i32* @uninteresting3) | ||
call void @use(i32* @uninteresting1, i32* @uninteresting2, i32* @uninteresting3) | ||
call void @use(i32* @uninteresting1, i32* @uninteresting2, i32* @uninteresting3) | ||
ret void | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters