[X86] Produce R_X86_64_GOTPCRELX for test/binop instructions (MOV32rm…

…/TEST32rm/...) when -Wa,-mrelax-relocations=yes is enabled We have been producing R_X86_64_REX_GOTPCRELX (MOV64rm/TEST64rm/...) and R_X86_64_GOTPCRELX for CALL64m/JMP64m without the REX prefix since 2016 (to be consistent with GNU as), but not for MOV32rm/TEST32rm/...
llvm · Oct 24, 2020 · f04d92a · f04d92a
1 parent 1e09dbb
commit f04d92a
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 22 deletions.
diff --git a/llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp b/llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp
@@ -229,6 +229,7 @@ class ELFLinkGraphBuilder_x86_64 {
     case ELF::R_X86_64_64:
       return ELF_x86_64_Edges::ELFX86RelocationKind::Pointer64;
     case ELF::R_X86_64_GOTPCREL:
+    case ELF::R_X86_64_GOTPCRELX:
     case ELF::R_X86_64_REX_GOTPCRELX:
       return ELF_x86_64_Edges::ELFX86RelocationKind::PCRel32GOTLoad;
     }

diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
@@ -404,6 +404,17 @@ void X86MCCodeEmitter::emitMemModRMByte(const MCInst &MI, unsigned Op,
       switch (Opcode) {
       default:
         return X86::reloc_riprel_4byte;
+      case X86::ADC32rm:
+      case X86::ADD32rm:
+      case X86::AND32rm:
+      case X86::CMP32rm:
+      case X86::MOV32rm:
+      case X86::OR32rm:
+      case X86::SBB32rm:
+      case X86::SUB32rm:
+      case X86::TEST32mr:
+      case X86::XOR32rm:
+        return X86::reloc_riprel_4byte_relax;
       case X86::MOV64rm:
         assert(HasREX);
         return X86::reloc_riprel_4byte_movq_load;

diff --git a/llvm/test/MC/ELF/got-relaxed.s b/llvm/test/MC/ELF/got-relaxed.s
diff --git a/llvm/test/MC/ELF/got.s b/llvm/test/MC/ELF/got.s
@@ -9,7 +9,7 @@
 // CHECK:      Relocations [
 // CHECK:        Section ({{[^ ]+}}) .rela.text {
 // CHECK-NEXT:       0x{{[^ ]+}} R_X86_64_GOT32 foo 0x{{[^ ]+}}
-// CHECK-NEXT:       0x{{[^ ]+}} R_X86_64_GOTPCREL foo 0x{{[^ ]+}}
+// CHECK-NEXT:       0x{{[^ ]+}} R_X86_64_GOTPCRELX foo 0x{{[^ ]+}}
 // CHECK-NEXT:   }
 // CHECK-NEXT: ]
 

diff --git a/llvm/test/MC/X86/gotpcrelx.s b/llvm/test/MC/X86/gotpcrelx.s
@@ -0,0 +1,49 @@
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s | llvm-readobj -r - | FileCheck %s
+# RUN: llvm-mc -filetype=obj -triple=x86_64 -relax-relocations=false %s | llvm-readobj -r - | FileCheck --check-prefix=NORELAX %s
+
+# CHECK:      Relocations [
+# CHECK-NEXT:   Section ({{.*}}) .rela.text {
+# CHECK-NEXT:     R_X86_64_GOTPCRELX mov
+# CHECK-NEXT:     R_X86_64_GOTPCRELX test
+# CHECK-NEXT:     R_X86_64_GOTPCRELX adc
+# CHECK-NEXT:     R_X86_64_GOTPCRELX add
+# CHECK-NEXT:     R_X86_64_GOTPCRELX and
+# CHECK-NEXT:     R_X86_64_GOTPCRELX cmp
+# CHECK-NEXT:     R_X86_64_GOTPCRELX or
+# CHECK-NEXT:     R_X86_64_GOTPCRELX sbb
+# CHECK-NEXT:     R_X86_64_GOTPCRELX sub
+# CHECK-NEXT:     R_X86_64_GOTPCRELX xor
+# CHECK-NEXT:     R_X86_64_GOTPCRELX call
+# CHECK-NEXT:     R_X86_64_GOTPCRELX jmp
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
+# NORELAX:      Relocations [
+# NORELAX-NEXT:   Section ({{.*}}) .rela.text {
+# NORELAX-NEXT:     R_X86_64_GOTPCREL mov
+# NORELAX-NEXT:     R_X86_64_GOTPCREL test
+# NORELAX-NEXT:     R_X86_64_GOTPCREL adc
+# NORELAX-NEXT:     R_X86_64_GOTPCREL add
+# NORELAX-NEXT:     R_X86_64_GOTPCREL and
+# NORELAX-NEXT:     R_X86_64_GOTPCREL cmp
+# NORELAX-NEXT:     R_X86_64_GOTPCREL or
+# NORELAX-NEXT:     R_X86_64_GOTPCREL sbb
+# NORELAX-NEXT:     R_X86_64_GOTPCREL sub
+# NORELAX-NEXT:     R_X86_64_GOTPCREL xor
+# NORELAX-NEXT:     R_X86_64_GOTPCREL call
+# NORELAX-NEXT:     R_X86_64_GOTPCREL jmp
+# NORELAX-NEXT:   }
+# NORELAX-NEXT: ]
+
+movl mov@GOTPCREL(%rip), %eax
+test %eax, test@GOTPCREL(%rip)
+adc adc@GOTPCREL(%rip), %eax
+add add@GOTPCREL(%rip), %eax
+and and@GOTPCREL(%rip), %eax
+cmp cmp@GOTPCREL(%rip), %eax
+or  or@GOTPCREL(%rip), %eax
+sbb sbb@GOTPCREL(%rip), %eax
+sub sub@GOTPCREL(%rip), %eax
+xor xor@GOTPCREL(%rip), %eax
+call *call@GOTPCREL(%rip)
+jmp *jmp@GOTPCREL(%rip)