add get/list probe command #204

shivam-Purohit · 2024-03-03T12:52:55Z

closes #176

This will add a new command to litmusctl that will enable the user to get the created probes in a given project

shivam-Purohit · 2024-03-03T12:58:35Z

there seems to be some permission issue in pre-commit file
@aryan-bhokare can you check that out?

aryan-bhokare · 2024-03-03T18:15:58Z

there seems to be some permission issue in pre-commit file @aryan-bhokare can you check that out?

Yep I'll check that. We have to manually give permissions I'll check to automate it.

shivam-Purohit · 2024-03-07T13:53:03Z

two things:

I cannot get the last row to align properly. I dont know exactly how to do that, i tried a bunch of combination
the probes arent getting filtered based on probeType I tried k8sprobe filter but its giving me all the http type ones. idk why

shivam-Purohit · 2024-03-07T14:10:48Z

./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a"

✔ Yes

You chose "Yes"

✔ cmdProbe

✔ done

Selected Probe Types: [cmdProbe]

PROBE ID		 PROBE TYPE		 CREATED AT		 CREATED BY

http probe test		httpProbe		admin		56047-11-12 19:12:28 +0530 IST

shivam			httpProbe		admin		56053-01-12 22:58:59 +0530 IST

shivamtest		httpProbe		admin		56140-09-13 09:17:28 +0530 IST

newhttp		httpProbe		admin		56142-12-05 08:29:41 +0530 IST

✔ Press Enter to show more probes (or type 'q' to quit): q█

./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a" --non-interactive=true --probe-types="k8sProbe, promProbe"

PROBE ID		 PROBE TYPE		 CREATED AT		 CREATED BY

http probe test		httpProbe		admin		56047-11-12 19:12:28 +0530 IST

shivam			httpProbe		admin		56053-01-12 22:58:59 +0530 IST

shivamtest		httpProbe		admin		56140-09-13 09:17:28 +0530 IST

newhttp		httpProbe		admin		56142-12-05 08:29:41 +0530 IST

Press Enter to show more probes (or type 'q' to quit): q

shivam-Purohit · 2024-03-13T05:24:21Z

./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a" 

✔ Yes

You chose "Yes"

✔ cmdProbe

✔ promProbe

✔ done

Selected Probe Types: [cmdProbe promProbe]

PROBE ID		 PROBE TYPE		 CREATED AT		 CREATED BY

No more probes to display

./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a" 

✔ Yes

You chose "Yes"

✔ httpProbe

✔ promProbe

✔ done

Selected Probe Types: [httpProbe promProbe]

PROBE ID		 PROBE TYPE		 CREATED AT		 CREATED BY

http probe test		httpProbe		admin		56047-11-12 19:12:28 +0530 IST

shivamtest		httpProbe		admin		56140-09-13 09:17:28 +0530 IST

newhttp		httpProbe		admin		56142-12-05 08:29:41 +0530 IST

Press Enter to show more probes (or type 'q' to quit): 

No more probes to display

Nageshbansal · 2024-03-14T02:59:46Z

pkg/cmd/get/probe.go

+			utils.White.Fprintln(writer, "CREATED BY\t", probeGetData.CreatedBy.Username)
+			utils.White.Fprintln(writer, "UPDATED AT\t", updatedTime)
+			utils.White.Fprintln(writer, "UPDATED BY\t", probeGetData.UpdatedBy.Username)
+			utils.White.Fprintln(writer, "TAGS\t", strings.Join(probeGetData.Tags, ", "))


Can we print all properties for a specific probe type, for e.g if HTTP probe prints URL, Criteria etc.

printed all the properties for different probe types

could you please share a screenshot for this

./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a" --probe-id="shivamcmd" PROBE DETAILS PROBE ID shivamcmd PROBE DESCRIPTION PROBE TYPE cmdProbe PROBE INFRASTRUCTURE TYPE Kubernetes TIMEOUT 1s INTERVAL 1s CREATED AT 56175-10-19 08:28:39 +0530 IST CREATED BY admin UPDATED AT 56175-10-19 08:28:39 +0530 IST UPDATED BY admin TAGS ./litmusctl get probes --project-id="8adf62d5-64f8-4c66-ab53-63729db9dd9a" ✔ No You chose "No" PROBE ID PROBE TYPE CREATED AT CREATED BY http probe test httpProbe admin 56047-11-12 19:12:28 +0530 IST newhttp httpProbe admin 56142-12-05 08:29:41 +0530 IST shivam99 httpProbe admin 56175-07-01 21:35:07 +0530 IST shivamcmd cmdProbe admin 56175-10-19 08:28:39 +0530 IST shivamcmd1 cmdProbe admin 56176-02-14 18:40:30 +0530 IST Press Enter to show more probes (or type 'q' to quit): q

pkg/cmd/get/get.go

Nageshbansal · 2024-03-14T03:03:14Z

pkg/cmd/get/probe.go

+
+var probesCmd = &cobra.Command{
+	Use:   "probes",
+	Short: "Display list of probes",


maybe we can write this: "Display a list or a specific probe"
WDYT @SarthakJain26 ?

How about "Details of a specific probe" we can avoid using "list"

yep, sounds good

but we are now majorly listing the probes and giving few details if passed probe_id. We are using describe for that right?

SarthakJain26 · 2024-03-18T09:58:26Z

pkg/cmd/get/probe.go

+		}
+		ProbeID, err := cmd.Flags().GetString("probe-id")
+
+		if ProbeID == "" {


@shivam-Purohit , please try to split the functions into multiple small functions, it will help in reducing the cognitive complexity

shivam-Purohit · 2024-03-21T13:34:05Z

its failing as soon as i rebased the master. But was working fine on local. what should i do?

Edit : fixed

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

Nageshbansal · 2024-03-22T10:18:36Z

pkg/apis/probe/query.go

+		  kubernetesHTTPProperties{
+			probeTimeout
+			interval
+			retry


Are we using all the properties? If not, then we can consider removing them from query

Nageshbansal · 2024-03-22T10:28:36Z

pkg/cmd/get/probe.go

+	totalProbes := len(probes_data)
+
+	writer := tabwriter.NewWriter(os.Stdout, 8, 8, 8, '\t', tabwriter.AlignRight)
+	utils.White_B.Fprintln(writer, "PROBE ID\t PROBE TYPE\t CREATED BY\t CREATED AT")


Let's have referencedBy also here ( as we also show this UI Overview )

done you can take a look

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

shivam-Purohit requested review from Jonsy13, Saranya-jena and SarthakJain26 as code owners March 3, 2024 12:52

shivam-Purohit force-pushed the probes_get branch from b87fc6f to 22f1d1d Compare March 5, 2024 14:28

shivam-Purohit changed the title ~~add get probe command~~ add get/list probe command Mar 7, 2024

Nageshbansal suggested changes Mar 14, 2024

View reviewed changes

shivam-Purohit requested a review from Nageshbansal March 16, 2024 10:13

SarthakJain26 requested changes Mar 18, 2024

View reviewed changes

shivam-Purohit force-pushed the probes_get branch from 7cb686f to fadf760 Compare March 21, 2024 13:07

shivam-Purohit added 13 commits March 21, 2024 19:09

fix

efa5627

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

add get/list probe command

966e489

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:fmt

7039f61

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

get-probes:add non-interactivte flag support

1b74e59

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:non-iteractive mode

534bf7c

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

add probe-id flag for probe details

8f589e6

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

improve logic for probe-id flag

6988455

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:filter query on listprobe command

958a385

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:fmt

a340bf3

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

get probe:add more details

c970333

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

refactor get probe command into smaller funcs

4c5789f

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:double printing of break statement get probe

9ad0d28

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix:fmt

e2e6e5b

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

shivam-Purohit force-pushed the probes_get branch from 5e60dfb to e2e6e5b Compare March 21, 2024 13:44

remove toolchain

63818c8

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

fix swap created by/at

263a556

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

Nageshbansal reviewed Mar 22, 2024

View reviewed changes

shivam-Purohit added 3 commits March 22, 2024 18:48

refactor the get probe cmd

c3c3cbf

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

remove unnecessary fields from get probe query

b20fd7a

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

add referencedBy in output get probe

8546861

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>

SarthakJain26 approved these changes Mar 29, 2024

View reviewed changes

SarthakJain26 requested a review from Nageshbansal March 29, 2024 11:05

Nageshbansal approved these changes Mar 29, 2024

View reviewed changes

SarthakJain26 merged commit 6b276da into litmuschaos:master Mar 29, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add get/list probe command #204

add get/list probe command #204

shivam-Purohit commented Mar 3, 2024

shivam-Purohit commented Mar 3, 2024

aryan-bhokare commented Mar 3, 2024

shivam-Purohit commented Mar 7, 2024 •

edited

Loading

shivam-Purohit commented Mar 7, 2024

shivam-Purohit commented Mar 13, 2024

Nageshbansal Mar 14, 2024

shivam-Purohit Mar 16, 2024

Nageshbansal Mar 18, 2024

shivam-Purohit Mar 21, 2024

Nageshbansal Mar 14, 2024

SarthakJain26 Mar 18, 2024

Nageshbansal Mar 18, 2024

shivam-Purohit Mar 21, 2024

SarthakJain26 Mar 18, 2024

shivam-Purohit Mar 21, 2024

shivam-Purohit commented Mar 21, 2024 •

edited

Loading

Nageshbansal Mar 22, 2024

Nageshbansal Mar 22, 2024

shivam-Purohit Mar 22, 2024

add get/list probe command #204

add get/list probe command #204

Conversation

shivam-Purohit commented Mar 3, 2024

shivam-Purohit commented Mar 3, 2024

aryan-bhokare commented Mar 3, 2024

shivam-Purohit commented Mar 7, 2024 • edited Loading

shivam-Purohit commented Mar 7, 2024

shivam-Purohit commented Mar 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shivam-Purohit commented Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shivam-Purohit commented Mar 7, 2024 •

edited

Loading

shivam-Purohit commented Mar 21, 2024 •

edited

Loading