Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smoke): Smoke test is missing ulid dependency to running inside the container. #3255

Merged
merged 1 commit into from
May 3, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

Motivation

Smoke test should be able to running in the cli container, but it is missing the ulid depenency.

Modification

Install ulid for smoke

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner May 3, 2024 01:00
@Wentao-Kuang Wentao-Kuang requested a review from blacha May 3, 2024 01:00
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit f14d0ba May 3, 2024
11 checks passed
@Wentao-Kuang Wentao-Kuang deleted the fix/smoke-ulid branch May 3, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants