Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong volume button palette #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rb-union
Copy link

Use QPushButton insead of custom paint,
set volume button background to transparent.

Log: Fix wrong volume button palette.
Bug: https://pms.uniontech.com/bug-view-234291.html

Use QPushButton insead of custom paint,
set volume button background to transparent.

Log: Fix wrong volume button palette.
Bug: https://pms.uniontech.com/bug-view-234291.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ToolboxProxy::slotThemeTypeChanged函数中,使用pa.setColor(DPalette::Light, QColor(Qt::transparent));pa.setColor(DPalette::Dark, QColor(Qt::transparent));来设置音量按钮的背景颜色,这可能会导致按钮的显示效果不正确,因为背景颜色设置为透明后,按钮上的图标也会显示为透明。
  • ToolboxProxy::updatePlayState函数中,重复设置m_pVolBtn的背景颜色,这可能是不必要的,应该检查是否有更合适的方式来处理主题类型的变化。
  • VolumeButton::setIcon函数中,使用QPushButton::setIcon(m_icon);来设置图标,这可能是为了修复图标显示不正确的问题,但这种方法可能会改变按钮的样式,需要确保这是预期的行为。
  • 移除了VolumeButton::paintEvent函数,这可能会影响按钮的绘制效果,需要确认这是否是预期的更改。
  • 删除了VolumeButton::wheelEvent函数中的注释,如果该函数的实现与预期不符,这可能会导致问题。

是否建议立即修改:

  • 需要确认ToolboxProxy::slotThemeTypeChangedToolboxProxy::updatePlayState函数中设置音量按钮背景颜色的更改是否正确,并确保按钮的显示效果符合预期。
  • 需要检查VolumeButton::setIcon函数中图标显示的更改是否符合设计要求,并确保按钮的样式和功能保持一致。
  • 如果移除VolumeButton::paintEvent函数是无意的,应该立即恢复该函数的实现,以避免潜在的显示问题。
  • 如果删除VolumeButton::wheelEvent函数中的注释是无意的,应该立即恢复该函数的实现,以避免潜在的功能问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants