fix(libdmr): strip LoongArch out of Platform::Mips #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
LoongArch is not MIPS-based Loongson and exhibits significantly different performance characteristics (try ~50 - 100% faster with current hardware versus 3A4000). There is no need to strip out functionalities in order to obtain acceptable performance. The current 3A6000 processors can easily keep up with 10th Gen Intel i3 processors.
MingcongBai
force-pushed
the
bai/loongarch64-fixup
branch
from
d7d206b
to
cf8bfc3
Compare
|
Re-submitted with company e-mail. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MingcongBai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MingcongBai The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoongArch is not MIPS-based Loongson and exhibits significantly different performance characteristics (try ~50 - 100% faster with current hardware versus 3A4000).
There is no need to strip out functionalities in order to obtain acceptable performance. The current 3A6000 processors can easily keep up with 10th Gen Intel i3 processors.