fel: Add support for allwinner T7 #204

qianfan-Zhao · 2024-01-02T10:43:51Z

uart0-helloworld-sdcard can work with this patch:

./sunxi-fel --verbose spl uart0-helloworld-sdboot.sunxi
Stack pointers: sp_irq=0x00022000, sp=0x00025E08
MMU is not enabled by BROM
=> Executing the SPL... done.

And next is the uart console's log:

Hello from Allwinner T7!
Returning back to FEL.

apritzel

That looks mostly good, thanks for sending this! Some comments inside.

apritzel · 2024-01-05T08:19:36Z

soc_info.c

+ * SRAM A1: 0x0002_0000 - 0x0002_7fff,  32K contains stacks
+ * SRAM  C: 0x0002_8000 - 0x0004_ffff, 160K full access
+ * SRAM A2: 0x0010_0000 - 0x0010_3fff,  16K unknown part, the data was changed
+ *                                          when read back


Does the T7 have an OpenRISC management core? Then this will probably be its exception vector area, where only one word in every 256 byte region is writable, as seen in the other OpenRISC SoCs.

I had not find the OpenRISC core in the datasheet. I had write 16KB zero data to this section and then readback, next is the new data:

$ hexdump -C 2.bin 00000000 00 00 00 00 00 00 00 15 00 00 00 00 00 00 00 00 |................| 00000010 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00000100 00 00 00 00 00 00 00 15 00 00 00 00 00 00 00 00 |................| 00000110 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00000200 00 00 00 00 00 00 00 15 00 00 00 00 00 00 00 00 |................| 00000210 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * ...

Maybe there only one word in every 256 byte region is not writable. And I don't known what the means of 0x15.

Yes,that's exactly the OpenRISC exception vector pattern we see in the other SoCs, compare here: https://linux-sunxi.org/A64/Memory_map

To elaborate: the first word is writable: that receives the branch instruction containing the target address of the exception handler. The 0x15000000 is the hardcoded NOP needed for the delay slot. The rest of each 256 byte region is not implemented and hardwired to 0.

apritzel · 2024-01-05T08:21:10Z

soc_info.c

+ */
+sram_swap_buffers t7_sram_swap_buffers[] = {
+	/* 0x21C00-0x21FFF (IRQ stack) */
+	{ .buf1 = 0x21C00, .buf2 = 0x4d800, .size = 0x0400 },


Do we need such a large stack? Do you know the stack pointer value?

I had write a tool like #130, write 1K random data everytime and then readback, when I write data to 0x21c00 the bootROM will hang. So I think this section size is 1K, maybe reducing the amount of data written each time will get a more accurate results, but that's not important.

when startting u-boot-spl in verbose mode, it will print the stack pointer value:

./sunxi-fel --verbose spl uart0-helloworld-sdboot.sunxi Stack pointers: sp_irq=0x00022000, sp=0x00025E08 MMU is not enabled by BROM => Executing the SPL... done.

the sp_irq value can match it.

Thanks for the stack pointers! Yes, the IRQ stack looks correct, both the size and location. I was wondering about the normal stack, though. Can you dump the BootROM somewhere? The initial FEL stack pointers are pretty easy to find in the disassembly, then we could reserve 5K down from there, to be on the safe side, and make sure the 0x25e08 is in that region.

apritzel · 2024-01-05T08:23:49Z

soc_info.c

+		.name         = "T7",
+		.spl_addr     = 0x20000,
+		.scratch_addr = 0x21000,
+		.thunk_addr   = 0x4d200, .thunk_size = 0x200,


There seems to be a gap between this thunk area and the swap buffers. Is that intentional? Can we move this area here up to end at the swap buffer's start?

No enough reason. The swap buffer is started at 0x4d800 and I make the thunk address before swap buffer. And reserve some space if we need extended the thunk_size in the future. Or maybe set thunk_size to 0x600 is better?

All other SoCs use 0x200, and the current code uses much less than that, If we would need more, we would need to change the value for all other SoCs, too. So there is no reason to go beyond 512 bytes, or to reserve space already.

apritzel · 2024-01-05T08:33:57Z

uart0-helloworld-sdboot.c

@@ -513,6 +515,10 @@ void gpio_init(void)
 		sunxi_gpio_set_cfgpin(SUNXI_GPE(2), SUN8I_R528_GPE_UART0);
 		sunxi_gpio_set_cfgpin(SUNXI_GPE(3), SUN8I_R528_GPE_UART0);
 		sunxi_gpio_set_pull(SUNXI_GPE(3), SUNXI_GPIO_PULL_UP);
+	} else if (soc_is_t7()) {


That looks to be the same as the A64. Can you please double check and then just add soc_is_t7() to the existing A64 check?

qianfan-Zhao · 2024-01-08T06:57:58Z

Hi @apritzel , the attachment is the N-BROM dump with https://github.com/DrSchottky/Allwinner-BROM-dumper:

$ ./dump 0 0xc000 T7-N-BRROM.bin 
BROM magic (eGON.BRM) found!
BROM header starts at 0x3000
BROM header size is 36
BROM boot version is 1100
BROM eGON is 1100
BROM platform is 1633
BROM dumped successfully!

The BROM set SP to 0x27ffc in the address 0x00003294 and I am not a good hacker for arm asm, could you please check it again?

T7-N-BROM.bin.gz

apritzel · 2024-01-10T17:43:45Z

Many thanks for the NBROM dump, that's very helpful!
So the FEL entry point is at 0x20, from there it branches to 0x70, and sets up the two stack pointers very early: the IRQ SP to 0x22000 (stored at 0x2ec), and the SVC SP to 0x27000 (stored at 0x2f0). Since the BROM also contains code for loading from MMC or NAND or SPI flash, there are more routines setting stack pointers, so I think the value you found belongs to other routines?
So with that it looks like just 5K would be enough. Can you check whether the area between 0x27000 and 0x28000 contains any data or is written to by the BROM during FEL operation? Then I guess we can reduce the stack backup buffer to 5K.

qianfan-Zhao · 2024-01-11T06:54:21Z

@apritzel you are right that the SVC sp is started at 0x27000. We can touch the data between 0x27000 and 0x27c00.

$ ./check.sh 0x27000 0x27fff  
Check region(1K) 0x27000 ...........
Check region(1K) 0x27400 ...........
Check region(1K) 0x27800 ...........
Check region(1K) 0x27C00 usb_bulk_send() ERROR -7: Operation timed out
usb_bulk_send() ERROR -7: Operation timed out
sha1sum doesn't match

The swap buffer of T7 is much more like H6, 0x27c00 is someting important and we also can not touch it.

Allwinner T7 share the same CCM/UART base address with H6. Add support for it in uart0-helloworld-sdboot. Signed-off-by: qianfan Zhao <qianfanguijin@163.com>

Copied from allwinner t7 linux 4.9 sdk Signed-off-by: qianfan Zhao <qianfanguijin@163.com>

apritzel

Awesome, many thanks for checking all the regions, and for the changes! Looks all good now, I also checked the SID maps for overlaps.

qianfan-Zhao force-pushed the allwinner-t7 branch from abe1937 to 73ef006 Compare January 2, 2024 10:48

apritzel requested changes Jan 5, 2024

View reviewed changes

qianfan-Zhao added 2 commits January 11, 2024 15:03

fel: Add support for allwinner T7

6c3ebfb

Allwinner T7 share the same CCM/UART base address with H6. Add support for it in uart0-helloworld-sdboot. Signed-off-by: qianfan Zhao <qianfanguijin@163.com>

soc_info: Add t7_sid_maps

e54002a

Copied from allwinner t7 linux 4.9 sdk Signed-off-by: qianfan Zhao <qianfanguijin@163.com>

qianfan-Zhao force-pushed the allwinner-t7 branch from 73ef006 to e54002a Compare January 11, 2024 07:08

qianfan-Zhao requested a review from apritzel January 11, 2024 07:09

apritzel approved these changes Jan 11, 2024

View reviewed changes

apritzel merged commit df60a46 into linux-sunxi:master Jan 11, 2024
1 check passed

qianfan-Zhao deleted the allwinner-t7 branch January 11, 2024 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fel: Add support for allwinner T7 #204

fel: Add support for allwinner T7 #204

qianfan-Zhao commented Jan 2, 2024

apritzel left a comment

apritzel Jan 5, 2024

qianfan-Zhao Jan 5, 2024

apritzel Jan 5, 2024

apritzel Jan 5, 2024

apritzel Jan 5, 2024

qianfan-Zhao Jan 5, 2024

apritzel Jan 5, 2024

apritzel Jan 5, 2024

qianfan-Zhao Jan 5, 2024 •

edited

Loading

apritzel Jan 5, 2024

apritzel Jan 5, 2024

qianfan-Zhao Jan 5, 2024

qianfan-Zhao commented Jan 8, 2024

apritzel commented Jan 10, 2024

qianfan-Zhao commented Jan 11, 2024

apritzel left a comment

fel: Add support for allwinner T7 #204

fel: Add support for allwinner T7 #204

Conversation

qianfan-Zhao commented Jan 2, 2024

apritzel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qianfan-Zhao Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qianfan-Zhao commented Jan 8, 2024

apritzel commented Jan 10, 2024

qianfan-Zhao commented Jan 11, 2024

apritzel left a comment

Choose a reason for hiding this comment

qianfan-Zhao Jan 5, 2024 •

edited

Loading