Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the workaround of removing resource up when empty ID #1582

Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

Moving the workround for crossplane to the correct location.

✔️ How to Test

N/A

@zliang-akamai zliang-akamai marked this pull request as ready for review September 18, 2024 16:21
@zliang-akamai zliang-akamai requested a review from a team as a code owner September 18, 2024 16:21
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-1 and removed request for a team September 18, 2024 16:21
@zliang-akamai zliang-akamai added the bugfix for any bug fixes in the changelog. label Sep 18, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all passing on my end, nice find!

@zliang-akamai zliang-akamai merged commit 2cf8c38 into linode:dev Sep 20, 2024
4 checks passed
@zliang-akamai zliang-akamai changed the title Move the workaround of removing resource when empty ID up Move the workaround of removing resource up when empty ID Sep 20, 2024
@zliang-akamai zliang-akamai deleted the zhiwei/fix-move-workaround-up branch September 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants