Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LKE node pool tests #556

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to fix the tests.

✔️ How to Test

make ARGS="-run TestLKENodePool" fixtures

@zliang-akamai zliang-akamai requested a review from a team as a code owner July 19, 2024 17:16
@zliang-akamai zliang-akamai requested review from ykim-1, yec-akamai and lgarber-akamai and removed request for a team July 19, 2024 17:16
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Jul 19, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ezilber-akamai ezilber-akamai self-requested a review July 19, 2024 19:15
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it quickly!

@zliang-akamai zliang-akamai merged commit 166a6b0 into main Jul 19, 2024
6 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/fix-lke-node-pool-tests branch July 19, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants