Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated profile_phone_number to regions from resty to request helpers #547

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated profile_phone_number to regions to request helpers

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner July 9, 2024 13:31
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and ykim-1 and removed request for a team July 9, 2024 13:31
@ezilber-akamai ezilber-akamai force-pushed the TPT-2879_profile_phone_number-regions branch 2 times, most recently from 0edba58 to 07898a1 Compare July 9, 2024 13:58
@ezilber-akamai ezilber-akamai marked this pull request as draft July 9, 2024 14:55
@ezilber-akamai ezilber-akamai force-pushed the TPT-2879_profile_phone_number-regions branch from 584fde5 to 6496cb0 Compare July 9, 2024 15:43
@ezilber-akamai ezilber-akamai force-pushed the TPT-2879_profile_phone_number-regions branch from 932d9c8 to 47e2ccb Compare July 9, 2024 16:44
@ezilber-akamai ezilber-akamai marked this pull request as ready for review July 9, 2024 16:49
@ezilber-akamai ezilber-akamai changed the title Migrated profile_phone_number to regions and reran fixtures Migrated profile_phone_number to regions from resty to request helpers Jul 9, 2024
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

// When opts (or opts.Page) is nil, all pages will be fetched and
// returned in a single (endpoint-specific)PagedResponse
// opts.results and opts.pages will be updated from the API response
func (c *Client) listHelper(ctx context.Context, pager PagedResponse, opts *ListOptions, ids ...any) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated that the fixtures are free of sensitive data and all PagedResponse structs are preserved. Nice work!

@ezilber-akamai ezilber-akamai merged commit 7a5aaec into linode:main Jul 19, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2879_profile_phone_number-regions branch July 19, 2024 14:30
@jriddle-linode jriddle-linode added enhancement issues that request a enhancement improvement for improvements in existing functionality in the changelog. and removed enhancement issues that request a enhancement labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants