Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated nodebalancer_firewalls to object_storage_clusters to request helpers #544

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated nodebalancer_firewalls to object_storage_clusters to request helpers

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner July 8, 2024 15:22
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team July 8, 2024 15:22
@lgarber-akamai
Copy link
Contributor

@ezilber-akamai Just a heads up, this PR might run into some conflicts with #522 depending on which one is merged first 👀

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, great work!

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests all pass with new fixtures

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and tests seem to be passing, nice work!

@ezilber-akamai ezilber-akamai merged commit aa85919 into linode:main Jul 11, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2877_nodebalancer_firewalls-object_storage_clusters branch July 11, 2024 14:47
@jriddle-linode jriddle-linode added enhancement issues that request a enhancement improvement for improvements in existing functionality in the changelog. and removed enhancement issues that request a enhancement labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants