Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated firewall_rules to instance_firewalls to request helpers #533

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Migrated firewall_rules to instance_firewalls to request helpers #533

merged 8 commits into from
Jul 8, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Migrated the following files to use request helpers:

  • firewall_rules.go
  • firewalls.go
  • instance_config_interfaces.go
  • instance_configs.go
  • instance_disks.go
  • instance_firewalls.go

@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch 2 times, most recently from 768a234 to 9f91900 Compare June 27, 2024 14:59
@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch from ef83a13 to fe6772e Compare June 27, 2024 15:57
@ezilber-akamai ezilber-akamai marked this pull request as ready for review June 27, 2024 16:02
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner June 27, 2024 16:02
@ezilber-akamai ezilber-akamai requested review from ykim-1 and yec-akamai and removed request for a team June 27, 2024 16:02
ykim-1
ykim-1 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the tests and fixtures related to firewall and instance locally

yec-akamai
yec-akamai approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though may need to fix a bunch of conflicts in fixtures

@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch 3 times, most recently from afe5d0b to fe6772e Compare July 2, 2024 13:41
@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch 2 times, most recently from a004c4c to 4fdfdf3 Compare July 5, 2024 20:36
@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch from 4fdfdf3 to 768d1b0 Compare July 5, 2024 20:40
@ezilber-akamai ezilber-akamai force-pushed the TPT-2873_firewall_rules-instance_firewalls branch from b22ca39 to 1d26edf Compare July 5, 2024 20:58
@ezilber-akamai ezilber-akamai merged commit 2a5ae92 into linode:main Jul 8, 2024
4 checks passed
@ezilber-akamai ezilber-akamai deleted the TPT-2873_firewall_rules-instance_firewalls branch July 8, 2024 16:48
@shanduur shanduur mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykim-1 ykim-1 ykim-1 approved these changes

@yec-akamai yec-akamai yec-akamai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezilber-akamai @ykim-1 @yec-akamai